Skip to content

Commit

Permalink
Align JPA sample with Hibernate 5.1’s table naming
Browse files Browse the repository at this point in the history
The name of the table for a many-to-many relationship has changed in
Hibernate 5.1.

This commit updates the JPA sample’s import.sql accordingly. It also
updates the repository integration tests to verify that the data has
been imported successfully.

Closes spring-projectsgh-5880
  • Loading branch information
wilkinsona committed May 10, 2016
1 parent 3ad334e commit 46407c6
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@ insert into note(title, body) values ('Spring Framework', 'Core support for depe
insert into note(title, body) values ('Spring Integration', 'Extends the Spring programming model to support the well-known Enterprise Integration Patterns.')
insert into note(title, body) values ('Tomcat', 'Apache Tomcat is an open source software implementation of the Java Servlet and JavaServer Pages technologies.')

insert into note_tags(notes_id, tags_id) values (1, 1)
insert into note_tags(notes_id, tags_id) values (2, 1)
insert into note_tags(notes_id, tags_id) values (3, 1)
insert into note_tags(notes_id, tags_id) values (1, 3)
insert into note_tags(notes_id, tags_id) values (2, 3)
insert into note_tags(notes_id, tags_id) values (3, 3)
insert into note_tags(notes_id, tags_id) values (4, 2)
insert into note_tags(notes_id, tags_id) values (4, 3)
insert into note_tag(notes_id, tags_id) values (1, 1)
insert into note_tag(notes_id, tags_id) values (2, 1)
insert into note_tag(notes_id, tags_id) values (3, 1)
insert into note_tag(notes_id, tags_id) values (1, 3)
insert into note_tag(notes_id, tags_id) values (2, 3)
insert into note_tag(notes_id, tags_id) values (3, 3)
insert into note_tag(notes_id, tags_id) values (4, 2)
insert into note_tag(notes_id, tags_id) values (4, 3)
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.test.context.SpringBootTest;
import org.springframework.test.context.junit4.SpringRunner;
import org.springframework.transaction.annotation.Transactional;

import static org.assertj.core.api.Assertions.assertThat;

Expand All @@ -34,6 +35,7 @@
*/
@RunWith(SpringRunner.class)
@SpringBootTest
@Transactional
public class JpaNoteRepositoryIntegrationTests {

@Autowired
Expand All @@ -43,6 +45,9 @@ public class JpaNoteRepositoryIntegrationTests {
public void findsAllNotes() {
List<Note> notes = this.repository.findAll();
assertThat(notes).hasSize(4);
for (Note note : notes) {
assertThat(note.getTags().size()).isGreaterThan(0);
}
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.test.context.SpringBootTest;
import org.springframework.test.context.junit4.SpringRunner;
import org.springframework.transaction.annotation.Transactional;

import static org.assertj.core.api.Assertions.assertThat;

Expand All @@ -34,6 +35,7 @@
*/
@RunWith(SpringRunner.class)
@SpringBootTest
@Transactional
public class JpaTagRepositoryIntegrationTests {

@Autowired
Expand All @@ -43,6 +45,9 @@ public class JpaTagRepositoryIntegrationTests {
public void findsAllTags() {
List<Tag> tags = this.repository.findAll();
assertThat(tags).hasSize(3);
for (Tag tag : tags) {
assertThat(tag.getNotes().size()).isGreaterThan(0);
}
}

}

0 comments on commit 46407c6

Please sign in to comment.