Skip to content

Commit

Permalink
Administration: use shorthand css properties to improve readability
Browse files Browse the repository at this point in the history
Consolidating `border`, `padding`, and `margin` instances where the shorthand can be used to improve readability.

Props ankitmaru, audrasjb, sabernhardt, mukesh27, hellofromTonya.
Fixes #52148.


Built from https://develop.svn.wordpress.org/trunk@50162


git-svn-id: http://core.svn.wordpress.org/trunk@49841 1a063a9b-81f0-0310-95a4-ce76da25c4cd
  • Loading branch information
aaronjorbin committed Feb 2, 2021
1 parent 9bab396 commit 56c9aa3
Show file tree
Hide file tree
Showing 29 changed files with 33 additions and 57 deletions.
3 changes: 1 addition & 2 deletions wp-admin/css/admin-menu-rtl.css
Original file line number Diff line number Diff line change
Expand Up @@ -459,13 +459,12 @@ ul#adminmenu > li.current > a.current:after {
/* flyout menu arrow */
#adminmenu li.wp-has-submenu.wp-not-current-submenu:hover:after {
left: 0;
border: solid transparent;
border: 8px solid transparent;
content: " ";
height: 0;
width: 0;
position: absolute;
pointer-events: none;
border-width: 8px;
top: 10px;
z-index: 10000;
}
Expand Down
2 changes: 1 addition & 1 deletion wp-admin/css/admin-menu-rtl.min.css

Large diffs are not rendered by default.

3 changes: 1 addition & 2 deletions wp-admin/css/admin-menu.css
Original file line number Diff line number Diff line change
Expand Up @@ -458,13 +458,12 @@ ul#adminmenu > li.current > a.current:after {
/* flyout menu arrow */
#adminmenu li.wp-has-submenu.wp-not-current-submenu:hover:after {
right: 0;
border: solid transparent;
border: 8px solid transparent;
content: " ";
height: 0;
width: 0;
position: absolute;
pointer-events: none;
border-width: 8px;
top: 10px;
z-index: 10000;
}
Expand Down
2 changes: 1 addition & 1 deletion wp-admin/css/admin-menu.min.css

Large diffs are not rendered by default.

6 changes: 2 additions & 4 deletions wp-admin/css/common-rtl.css
Original file line number Diff line number Diff line change
Expand Up @@ -2701,9 +2701,8 @@ div.action-links {
right: 0;
margin-top: 10px;
margin-left: 250px; /* FYI box */
padding: 10px 26px;
padding: 10px 26px 99999px; /* equal height column trick */
margin-bottom: -99932px; /* 67px less than the padding below to accommodate footer height */
padding-bottom: 99999px; /* equal height column trick */
}

#section-holder .notice {
Expand All @@ -2719,9 +2718,8 @@ div.action-links {
position: relative;
top: 0;
left: 0;
padding: 16px;
padding: 16px 16px 99999px; /* equal height column trick */
margin-bottom: -99932px; /* 67px less than the padding below to accommodate footer height */
padding-bottom: 99999px; /* equal height column trick */
width: 217px;
border-right: 1px solid #dcdcde;
background: #f6f7f7;
Expand Down
2 changes: 1 addition & 1 deletion wp-admin/css/common-rtl.min.css

Large diffs are not rendered by default.

6 changes: 2 additions & 4 deletions wp-admin/css/common.css
Original file line number Diff line number Diff line change
Expand Up @@ -2700,9 +2700,8 @@ div.action-links {
left: 0;
margin-top: 10px;
margin-right: 250px; /* FYI box */
padding: 10px 26px;
padding: 10px 26px 99999px; /* equal height column trick */
margin-bottom: -99932px; /* 67px less than the padding below to accommodate footer height */
padding-bottom: 99999px; /* equal height column trick */
}

#section-holder .notice {
Expand All @@ -2718,9 +2717,8 @@ div.action-links {
position: relative;
top: 0;
right: 0;
padding: 16px;
padding: 16px 16px 99999px; /* equal height column trick */
margin-bottom: -99932px; /* 67px less than the padding below to accommodate footer height */
padding-bottom: 99999px; /* equal height column trick */
width: 217px;
border-left: 1px solid #dcdcde;
background: #f6f7f7;
Expand Down
2 changes: 1 addition & 1 deletion wp-admin/css/common.min.css

Large diffs are not rendered by default.

6 changes: 2 additions & 4 deletions wp-admin/css/customize-controls-rtl.css
Original file line number Diff line number Diff line change
Expand Up @@ -2369,8 +2369,7 @@ body.cheatin h1 {
font-size: 24px;
font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, Oxygen-Sans, Ubuntu, Cantarell, "Helvetica Neue", sans-serif;
margin: 30px 0 0 0;
padding: 0;
padding-bottom: 7px;
padding: 0 0 7px;
}

body.cheatin p {
Expand All @@ -2388,8 +2387,7 @@ body.cheatin p {
#customize-theme-controls .add-new-menu-item {
cursor: pointer;
float: left;
margin: 0;
margin-right: 10px;
margin: 0 10px 0 0;
transition: all 0.2s;
-webkit-user-select: none;
-ms-user-select: none;
Expand Down
2 changes: 1 addition & 1 deletion wp-admin/css/customize-controls-rtl.min.css

Large diffs are not rendered by default.

6 changes: 2 additions & 4 deletions wp-admin/css/customize-controls.css
Original file line number Diff line number Diff line change
Expand Up @@ -2368,8 +2368,7 @@ body.cheatin h1 {
font-size: 24px;
font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, Oxygen-Sans, Ubuntu, Cantarell, "Helvetica Neue", sans-serif;
margin: 30px 0 0 0;
padding: 0;
padding-bottom: 7px;
padding: 0 0 7px;
}

body.cheatin p {
Expand All @@ -2387,8 +2386,7 @@ body.cheatin p {
#customize-theme-controls .add-new-menu-item {
cursor: pointer;
float: right;
margin: 0;
margin-left: 10px;
margin: 0 0 0 10px;
transition: all 0.2s;
-webkit-user-select: none;
-ms-user-select: none;
Expand Down
2 changes: 1 addition & 1 deletion wp-admin/css/customize-controls.min.css

Large diffs are not rendered by default.

5 changes: 1 addition & 4 deletions wp-admin/css/edit-rtl.css
Original file line number Diff line number Diff line change
Expand Up @@ -1851,10 +1851,7 @@ table.links-table {
}

.wp_themeSkin .mceSplitButton td a.mceAction {
padding-top: 6px;
padding-bottom: 6px;
padding-right: 6px;
padding-left: 3px;
padding: 6px 6px 6px 3px;
}

.wp_themeSkin .mceSplitButton td a.mceOpen,
Expand Down
2 changes: 1 addition & 1 deletion wp-admin/css/edit-rtl.min.css

Large diffs are not rendered by default.

5 changes: 1 addition & 4 deletions wp-admin/css/edit.css
Original file line number Diff line number Diff line change
Expand Up @@ -1850,10 +1850,7 @@ table.links-table {
}

.wp_themeSkin .mceSplitButton td a.mceAction {
padding-top: 6px;
padding-bottom: 6px;
padding-left: 6px;
padding-right: 3px;
padding: 6px 3px 6px 6px;
}

.wp_themeSkin .mceSplitButton td a.mceOpen,
Expand Down
2 changes: 1 addition & 1 deletion wp-admin/css/edit.min.css

Large diffs are not rendered by default.

3 changes: 1 addition & 2 deletions wp-admin/css/install-rtl.css
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,7 @@ h1, h2 {
clear: both;
color: #646970;
font-size: 24px;
padding: 0;
padding-bottom: 7px;
padding: 0 0 7px;
font-weight: 400;
}

Expand Down
2 changes: 1 addition & 1 deletion wp-admin/css/install-rtl.min.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions wp-admin/css/install.css
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,7 @@ h1, h2 {
clear: both;
color: #646970;
font-size: 24px;
padding: 0;
padding-bottom: 7px;
padding: 0 0 7px;
font-weight: 400;
}

Expand Down
Loading

0 comments on commit 56c9aa3

Please sign in to comment.