Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Test if rule format is valid #2795

Merged
merged 4 commits into from
Dec 13, 2024
Merged

Conversation

thomaspoignant
Copy link
Owner

Description

Basic rule query check validation for the linter and to validate the flags.

Closes issue(s)

#2786

Checklist

  • I have tested this code
  • I have added unit test to cover this code
  • I have followed the contributing guide

Signed-off-by: Thomas Poignant <[email protected]>
Copy link

netlify bot commented Dec 13, 2024

Deploy Preview for go-feature-flag-doc-preview canceled.

Name Link
🔨 Latest commit ba37597
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/675c822896e66200089920b2

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.

Project coverage is 84.77%. Comparing base (8ae0c6d) to head (ba37597).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/flag/rule.go 83.33% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2795      +/-   ##
==========================================
- Coverage   84.78%   84.77%   -0.02%     
==========================================
  Files         111      111              
  Lines        5191     5207      +16     
==========================================
+ Hits         4401     4414      +13     
- Misses        626      628       +2     
- Partials      164      165       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomaspoignant thomaspoignant merged commit 473c8f3 into main Dec 13, 2024
22 of 23 checks passed
@thomaspoignant thomaspoignant deleted the feat-add-check-rule-format branch December 13, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant