Skip to content

Commit

Permalink
zram: use zram_free_page instead of open-coded
Browse files Browse the repository at this point in the history
The zram_free_page already handles NULL handle case and same page so use
it to reduce error probability.  (Acutaully, I made a mistake when I
handled same page feature)

Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Minchan Kim <[email protected]>
Cc: Hannes Reinecke <[email protected]>
Cc: Johannes Thumshirn <[email protected]>
Cc: Sergey Senozhatsky <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
minchank authored and torvalds committed May 3, 2017
1 parent 643ae61 commit 302128d
Showing 1 changed file with 3 additions and 14 deletions.
17 changes: 3 additions & 14 deletions drivers/block/zram/zram_drv.c
Original file line number Diff line number Diff line change
Expand Up @@ -480,17 +480,8 @@ static void zram_meta_free(struct zram *zram, u64 disksize)
size_t index;

/* Free all pages that are still in this zram device */
for (index = 0; index < num_pages; index++) {
unsigned long handle = zram_get_handle(zram, index);
/*
* No memory is allocated for same element filled pages.
* Simply clear same page flag.
*/
if (!handle || zram_test_flag(zram, index, ZRAM_SAME))
continue;

zs_free(zram->mem_pool, handle);
}
for (index = 0; index < num_pages; index++)
zram_free_page(zram, index);

zs_destroy_pool(zram->mem_pool);
vfree(zram->table);
Expand Down Expand Up @@ -978,9 +969,6 @@ static void zram_reset_device(struct zram *zram)

comp = zram->comp;
disksize = zram->disksize;

/* Reset stats */
memset(&zram->stats, 0, sizeof(zram->stats));
zram->disksize = 0;

set_capacity(zram->disk, 0);
Expand All @@ -989,6 +977,7 @@ static void zram_reset_device(struct zram *zram)
up_write(&zram->init_lock);
/* I/O operation under all of CPU are done so let's free */
zram_meta_free(zram, disksize);
memset(&zram->stats, 0, sizeof(zram->stats));
zcomp_destroy(comp);
}

Expand Down

0 comments on commit 302128d

Please sign in to comment.