Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed compile errors after last Qt 5.4 patch #29

Merged
merged 1 commit into from
Nov 11, 2014
Merged

Fixed compile errors after last Qt 5.4 patch #29

merged 1 commit into from
Nov 11, 2014

Conversation

greenaddress
Copy link
Contributor

This changes argument references in Converter::type, QVariantListIterator and QVariantDictIterator to const to allow using QVariant::value<QJSValue>() return values directly.

Also changes QVariantConverter::dict return value to return QVariantDictIterator correctly.

@greenaddress greenaddress mentioned this pull request Nov 11, 2014
Closed
thp added a commit that referenced this pull request Nov 11, 2014
@thp
Merge pull request #29 from greenaddress/qt5.4
26612b0 
Fixed compile errors after last Qt 5.4 patch
@thp thp merged commit 26612b0 into thp:master Nov 11, 2014
@greenaddress
Copy link
Contributor Author

@thp thanks!

@thp thp mentioned this pull request Jan 2, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@greenaddress @thp