Skip to content

Commit

Permalink
[dev.link] cmd/link: stop marking DWARF constant symbols
Browse files Browse the repository at this point in the history
DWARF constant symbols were always marked and converted to
sym.Symbols when DWARF generation uses sym.Symbols. Now that the
DWARF generation uses the loader, no need to force-mark them.

Change-Id: Ia4032430697cfa901fb4b6d106a483973277ea0a
Reviewed-on: https://go-review.googlesource.com/c/go/+/226803
Reviewed-by: Than McIntosh <[email protected]>
Reviewed-by: Jeremy Faller <[email protected]>
  • Loading branch information
cherrymui committed Apr 1, 2020
1 parent cc3039f commit 8cc515a
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions src/cmd/link/internal/ld/deadcode2.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ package ld

import (
"bytes"
"cmd/internal/dwarf"
"cmd/internal/objabi"
"cmd/internal/sys"
"cmd/link/internal/loader"
Expand Down Expand Up @@ -101,14 +100,6 @@ func (d *deadcodePass2) init() {
names = append(names, exp)
}

// DWARF constant DIE symbols are not referenced, but needed by
// the dwarf pass.
if !*FlagW {
for _, lib := range d.ctxt.Library {
names = append(names, dwarf.ConstInfoPrefix+lib.Pkg)
}
}

for _, name := range names {
// Mark symbol as a data/ABI0 symbol.
d.mark(d.ldr.Lookup(name, 0), 0)
Expand Down

0 comments on commit 8cc515a

Please sign in to comment.