handle idle recycle duration is 0

gp.go

@@ -42,10 +42,30 @@ func worker(p *Pool, fn func()) {
 	default:
 		return
 	}
+	defer func() { <-p.count }()
 
 	// Enter the worker loop.
-	done := false
+	if p.idleRecycle == 0 {
+		workerLoopSimple(p)
+	} else {
+		workerLoop(p)
+	}
+}
+
+func workerLoopSimple(p *Pool) {
+	for {
+		select {
+		case f := <-p.ch:
+			f()
+		case <-p.closed:
+			return
+		}
+	}
+}
+
+func workerLoop(p *Pool) {
 	t := time.NewTimer(p.idleRecycle)
+	done := false
 	for !done {
 		select {
 		case f := <-p.ch:
@@ -60,7 +80,6 @@ func worker(p *Pool, fn func()) {
 			done = true
 		}
 	}
-	<-p.count
 }
 
 // Close releases the goroutines in the Pool.

gp_test.go

@@ -25,3 +25,47 @@ func TestT(t *testing.T) {
 		t.Fail()
 	}
 }
+
+func TestPanic(t *testing.T) {
+	pool := New(2, 0)
+	// Fill the pool
+	for i:=0; i<10; i++ {
+		pool.Go(func() {})
+	}
+	time.Sleep(100*time.Millisecond)
+	for i := 0; i < 100; i++ {
+		pool.Go(func() {
+			defer func() {
+				if r := recover(); r != nil {
+				}
+			}()
+			panic(1)
+		})
+	}
+	time.Sleep(100*time.Millisecond)
+	if len(pool.count) != 2 {
+		t.Fail()
+	}
+}
+
+func TestIdleRecycle(t *testing.T) {
+	pool := New(10, 100*time.Millisecond)
+	for i:=0; i<1000; i++ {
+		pool.Go(func(){})
+	}
+	time.Sleep(300*time.Millisecond)
+	if len(pool.count) != 0 {
+		t.Fail()
+	}
+	pool.Close()
+
+	pool = New(10, 0)
+	for i:=0; i<1000; i++ {
+		pool.Go(func(){})
+	}
+	time.Sleep(300*time.Millisecond)
+	if len(pool.count) == 0 {
+		t.Fail()
+	}
+	pool.Close()
+}