fix: add eager result to stream, rebuild query widget on var change

tiendatz · Aug 29, 2019 · af89b19 · af89b19
1 parent 5f938e4
commit af89b19
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/packages/graphql/lib/src/core/observable_query.dart b/packages/graphql/lib/src/core/observable_query.dart
@@ -104,6 +104,13 @@ class ObservableQuery {
   void onListen() {
     if (_latestWasEagerlyFetched) {
       _latestWasEagerlyFetched = false;
+
+      // eager results are resolved synchronously,
+      // so we have to add them manually now that
+      // the stream is available
+      if (!controller.isClosed && latestResult != null) {
+        controller.add(latestResult);
+      }
       return;
     }
     if (options.fetchResults) {

diff --git a/packages/graphql_flutter/README.md b/packages/graphql_flutter/README.md
@@ -249,7 +249,7 @@ FetchMoreOptions opts = FetchMoreOptions(
     ];
 
     // to avoid a lot of work, lets just update the list of repos in returned
-    // data with new data, this also ensure we have the endCursor already set
+    // data with new data, this also ensures we have the endCursor already set
     // correctly
     fetchMoreResultData['search']['nodes'] = repos;
 

diff --git a/packages/graphql_flutter/lib/src/widgets/query.dart b/packages/graphql_flutter/lib/src/widgets/query.dart
@@ -86,6 +86,7 @@ class QueryState extends State<Query> {
   @override
   Widget build(BuildContext context) {
     return StreamBuilder<QueryResult>(
+      key: Key(observableQuery?.options?.toKey()),
       initialData: observableQuery?.latestResult ?? QueryResult(loading: true),
       stream: observableQuery.stream,
       builder: (