Verify USB listener callback handle

Do not use `handle` if `libusb_hotplug_register_callback` fails
tigerwill90 · Jun 23, 2024 · a1ddb45 · a1ddb45
1 parent 266c025
commit a1ddb45
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/src/gui/osutils/nixutils/DeviceListenerLibUsb.cpp b/src/gui/osutils/nixutils/DeviceListenerLibUsb.cpp
@@ -97,11 +97,13 @@ DeviceListenerLibUsb::registerHotplugCallback(bool arrived, bool left, int vendo
         // Avoid race conditions
         m_usbEvents.waitForFinished();
     }
-    if (!m_usbEvents.isRunning()) {
-        m_completed = false;
-        m_usbEvents = QtConcurrent::run(handleUsbEvents, static_cast<libusb_context*>(m_ctx), &m_completed);
+    if (handle > 0) {
+        m_callbackHandles.insert(handle);
+        if (!m_usbEvents.isRunning()) {
+            m_completed = false;
+            m_usbEvents = QtConcurrent::run(handleUsbEvents, static_cast<libusb_context*>(m_ctx), &m_completed);
+        }
     }
-    m_callbackHandles.insert(handle);
     return handle;
 }