Upgrade the PD client to adopt the latest refactor #1525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
dco-signoff: yes
JmPotato
force-pushed
the
update_pd_client
branch
from
667b9ab to
3e47981
Compare
This was referenced Dec 17, 2024
Closed
rleungx
reviewed
Dec 17, 2024
integration_tests/pd_api_test.go
Outdated
| @@ -49,7 +50,7 @@ type apiTestSuite struct { | |||
| func (s *apiTestSuite) SetupTest() { | |||
| require := s.Require() | |||
| addrs := strings.Split(*pdAddrs, ",") | |||
| pdClient, err := pd.NewClient(addrs, pd.SecurityOption{}) | |||
| pdClient, err := pd.NewClient(caller.Component("client-go-integration-test"), addrs, pd.SecurityOption{}) | |||
There was a problem hiding this comment.
@okJiang Do we have a standard for the definition of the component?
There was a problem hiding this comment.
If it is in the test, we can use caller.TestComponent. Otherwise, we can put it empty now, I will update them in #1516
There was a problem hiding this comment.
BTW, how about adding a DefaultComponent = "" in pd repo?
you06
approved these changes
Dec 17, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
Signed-off-by: JmPotato <[email protected]>
Signed-off-by: JmPotato <[email protected]>
Signed-off-by: JmPotato <[email protected]>
JmPotato
force-pushed
the
update_pd_client
branch
2 times, most recently
from
588f013 to
1b9895b
Compare
Signed-off-by: JmPotato <[email protected]>
JmPotato
force-pushed
the
update_pd_client
branch
from
1b9895b to
1dcf3e6
Compare
rleungx
approved these changes
Dec 20, 2024
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rleungx, you06 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration testing can only resume normal operation after TiDB has completed its update.