region_cache: fix a potential data race on store.addr #1545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zyguan <[email protected]>
ti-chi-bot
bot
added
dco-signoff: yes
asddongmen
approved these changes
Jan 7, 2025
|
@asddongmen: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
cfzjywxk
approved these changes
Jan 13, 2025
ti-chi-bot
bot
added
needs-1-more-lgtm
crazycs520
approved these changes
Jan 13, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: asddongmen, cfzjywxk, crazycs520 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1544
store.addris mutable, it gets updated when: 1.initResolve2.refreshFullStoreList, to avoid data race, we use storeID (which is immutable) as the value of the metric label.