Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: better metrics support #24

Merged
merged 5 commits into from
Jun 27, 2019
Merged

*: better metrics support #24

merged 5 commits into from
Jun 27, 2019

Conversation

disksing
Copy link
Collaborator

  • Add grafana template
  • Adjust metrics
  • Add bench example

Fixes #22

@disksing disksing requested a review from rleungx June 19, 2019 04:14
siddontang
siddontang reviewed Jun 26, 2019
View reviewed changes
txnkv/txn.go Outdated Show resolved Hide resolved
rleungx
rleungx reviewed Jun 26, 2019
View reviewed changes
metrics/metrics.go
@@ -34,14 +43,6 @@ var (
Help: "Counter of snapshots.",
})

TxnCmdCounter = prometheus.NewCounterVec(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it not useful anymore?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Command duration already contains count so it can be removed.

disksing added 2 commits June 26, 2019 14:27
@disksing
address comment
5e299d3 
Signed-off-by: disksing <[email protected]>
@disksing
minor cleanup
d94869c 
Signed-off-by: disksing <[email protected]>
@disksing disksing merged commit 27e9cc9 into tikv:master Jun 27, 2019
@disksing disksing deleted the metrics branch June 27, 2019 16:38
daimashusheng pushed a commit to daimashusheng/client-go that referenced this pull request Sep 2, 2021
@disksing
*: better metrics support (tikv#24)
2c7a3dd 
* support push metrics

Signed-off-by: disksing <[email protected]>

* cleanup metrics and add grafana template

Signed-off-by: disksing <[email protected]>

* address comment

Signed-off-by: disksing <[email protected]>

* minor cleanup

Signed-off-by: disksing <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siddontang siddontang siddontang left review comments

@rleungx rleungx rleungx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better metrics support
3 participants
@disksing @siddontang @rleungx