Merge pull request wesbos#76 from Asjas/update-production-deployment

Update production deployment config
timOTdev · Nov 29, 2021 · 7061e20 · 7061e20
2 parents 18eb524 + 6d6f67f
commit 7061e20
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 2 deletions.
diff --git a/starter-files/package.json b/starter-files/package.json
@@ -7,6 +7,7 @@
   },
   "scripts": {
     "prod": "node ./start.js",
+    "build": "webpack",
     "watch": "nodemon ./start.js --ignore public/",
     "start": "concurrently \"npm run watch\" \"npm run assets\" --names \"💻,📦\" --prefix name",
     "assets": "webpack -w",

diff --git a/starter-files/webpack.config.js b/starter-files/webpack.config.js
@@ -4,7 +4,7 @@
 const path = require("path");
 const MiniCssExtractPlugin = require("mini-css-extract-plugin");
 const env = require("dotenv").config({ path: "variables.env" });
-const nodeEnv = env.parsed.NODE_ENV;
+const nodeEnv = process.env.NODE_ENV || env.parsed.NODE_ENV;
 
 /*
   webpack sees every file as a module.

diff --git a/stepped-solutions/45 - Finished App/package.json b/stepped-solutions/45 - Finished App/package.json
@@ -7,6 +7,7 @@
   },
   "scripts": {
     "prod": "node ./start.js",
+    "build": "webpack",
     "watch": "nodemon ./start.js --ignore public/",
     "start": "concurrently \"npm run watch\" \"npm run assets\" --names \"💻,📦\" --prefix name",
     "assets": "webpack -w",

diff --git a/stepped-solutions/45 - Finished App/webpack.config.js b/stepped-solutions/45 - Finished App/webpack.config.js
@@ -4,7 +4,7 @@
 const path = require("path");
 const MiniCssExtractPlugin = require("mini-css-extract-plugin");
 const env = require("dotenv").config({ path: "variables.env" });
-const nodeEnv = env.parsed.NODE_ENV;
+const nodeEnv = process.env.NODE_ENV || env.parsed.NODE_ENV;
 
 /*
   webpack sees every file as a module.