Skip to content

Commit

Permalink
Fix GCSettings.LatencyMode test TODO (dotnet#51547)
Browse files Browse the repository at this point in the history
  • Loading branch information
jkotas authored Apr 20, 2021
1 parent 1724c46 commit 53e713f
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions src/libraries/System.Runtime/tests/System/GCTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -422,6 +422,8 @@ public static void LargeObjectHeapCompactionModeRoundTrips(GCLargeObjectHeapComp
[ActiveIssue("https://github.com/dotnet/runtime/issues/31657", TestRuntimes.Mono)]
[InlineData(GCLatencyMode.Batch)]
[InlineData(GCLatencyMode.Interactive)]
[InlineData(GCLatencyMode.LowLatency)]
[InlineData(GCLatencyMode.SustainedLowLatency)]
public static void LatencyRoundtrips(GCLatencyMode value)
{
GCLatencyMode orig = GCSettings.LatencyMode;
Expand All @@ -436,13 +438,6 @@ public static void LatencyRoundtrips(GCLatencyMode value)
Assert.Equal(orig, GCSettings.LatencyMode);
}
}

[Theory]
[ActiveIssue("https://github.com/dotnet/runtime/issues/31657", TestPlatforms.Windows, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
[PlatformSpecific(TestPlatforms.Windows)] //Concurrent GC is not enabled on Unix. Recombine to TestLatencyRoundTrips once addressed.
[InlineData(GCLatencyMode.LowLatency)]
[InlineData(GCLatencyMode.SustainedLowLatency)]
public static void LatencyRoundtrips_LowLatency(GCLatencyMode value) => LatencyRoundtrips(value);
}

public class GCExtendedTests
Expand Down

0 comments on commit 53e713f

Please sign in to comment.