get last error before calling a method that might fail as well (dotne…

…t#54667)
timandy · Jun 24, 2021 · 72deae8 · 72deae8
1 parent 7833828
commit 72deae8
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/libraries/System.Private.CoreLib/src/Microsoft/Win32/SafeHandles/SafeFileHandle.Unix.cs b/src/libraries/System.Private.CoreLib/src/Microsoft/Win32/SafeHandles/SafeFileHandle.Unix.cs
@@ -44,8 +44,8 @@ private static SafeFileHandle Open(string path, Interop.Sys.OpenFlags flags, int
 
             if (handle.IsInvalid)
             {
-                handle.Dispose();
                 Interop.ErrorInfo error = Interop.Sys.GetLastErrorInfo();
+                handle.Dispose();
 
                 // If we fail to open the file due to a path not existing, we need to know whether to blame
                 // the file itself or its directory.  If we're creating the file, then we blame the directory,
@@ -70,8 +70,9 @@ private static SafeFileHandle Open(string path, Interop.Sys.OpenFlags flags, int
             Interop.Sys.FileStatus status;
             if (Interop.Sys.FStat(handle, out status) != 0)
             {
+                Interop.ErrorInfo error = Interop.Sys.GetLastErrorInfo();
                 handle.Dispose();
-                throw Interop.GetExceptionForIoErrno(Interop.Sys.GetLastErrorInfo(), path);
+                throw Interop.GetExceptionForIoErrno(error, path);
             }
             if ((status.Mode & Interop.Sys.FileTypes.S_IFMT) == Interop.Sys.FileTypes.S_IFDIR)
             {