Skip to content

Commit

Permalink
Always generate metadata for dynamic methods (dotnet#72315) (dotnet#7…
Browse files Browse the repository at this point in the history
…7322)

Co-authored-by: David Mason <[email protected]>
  • Loading branch information
tommcdon and davmason authored Nov 3, 2022
1 parent 6376e01 commit a53eb8c
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions src/coreclr/vm/ceeload.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -12594,15 +12594,6 @@ void ReflectionModule::CaptureModuleMetaDataToMemory()
}
CONTRACTL_END;

// If a debugger is attached, then the CLR will still send ClassLoad notifications for dynamic modules,
// which mean we still need to keep the metadata available. This is the same as Whidbey.
// An alternative (and better) design would be to suppress ClassLoad notifications too, but then we'd
// need some way of sending a "catchup" notification to the debugger after we re-enable notifications.
if (!CORDebuggerAttached())
{
return;
}

// Do not release the emitter. This is a weak reference.
IMetaDataEmit *pEmitter = this->GetEmitter();
_ASSERTE(pEmitter != NULL);
Expand Down

0 comments on commit a53eb8c

Please sign in to comment.