forked from dotnet/runtime
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'upstream-master' into master
- Loading branch information
Showing
13,535 changed files
with
798,748 additions
and
428,968 deletions.
The diff you're trying to view is too large. We only load the first 3000 changed files.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validating CODEOWNERS rules …
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| name: API Suggestion | ||
| description: Propose a change to the public API surface | ||
| title: "[API Proposal]: " | ||
| labels: [api-suggestion] | ||
| body: | ||
| - type: markdown | ||
| attributes: | ||
| value: | | ||
| We welcome API proposals! We have a process to evaluate the value and shape of new API. There is an overview of our process [here](https://github.com/dotnet/runtime/blob/main/docs/project/api-review-process.md). This template will help us gather the information we need to start the review process. | ||
| - type: textarea | ||
| id: background | ||
| attributes: | ||
| label: Background and motivation | ||
| description: Please describe the purpose and value of the new API here. | ||
| placeholder: Purpose | ||
| validations: | ||
| required: true | ||
| - type: textarea | ||
| id: api-proposal | ||
| attributes: | ||
| label: API Proposal | ||
| description: | | ||
| Please provide the specific public API signature diff that you are proposing. | ||
| You may find the [Framework Design Guidelines](https://github.com/dotnet/runtime/blob/main/docs/coding-guidelines/framework-design-guidelines-digest.md) helpful. | ||
| placeholder: API declaration (no method bodies) | ||
| value: | | ||
| ```C# | ||
| namespace System.Collections.Generic | ||
| { | ||
| public class MyFancyCollection<T> : IEnumerable<T> | ||
| { | ||
| public void Fancy(T item); | ||
| } | ||
| } | ||
| ``` | ||
| validations: | ||
| required: true | ||
| - type: textarea | ||
| id: api-usage | ||
| attributes: | ||
| label: API Usage | ||
| description: | | ||
| Please provide code examples that highlight how the proposed API additions are meant to be consumed. This will help suggest whether the API has the right shape to be functional, performant and useable. | ||
| placeholder: API usage | ||
| value: | | ||
| ```C# | ||
| // Fancy the value | ||
| var c = new MyFancyCollection<int>(); | ||
| c.Fancy(42); | ||
| // Getting the values out | ||
| foreach (var v in c) | ||
| Console.WriteLine(v); | ||
| ``` | ||
| validations: | ||
| required: true | ||
| - type: textarea | ||
| id: risks | ||
| attributes: | ||
| label: Risks | ||
| description: | | ||
| Please mention any risks that to your knowledge the API proposal might entail, such as breaking changes, performance regressions, etc. | ||
| placeholder: Risks | ||
| validations: | ||
| required: false |
2 changes: 1 addition & 1 deletion
2
.github/PULL_REQUEST_TEMPLATE/servicing_pull_request_template.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "problemMatcher": [ | ||
| { | ||
| "owner": "markdownlint", | ||
| "pattern": [ | ||
| { | ||
| "regexp": "^([^:]*):(\\d+):?(\\d+)?\\s([\\w-\\/]*)\\s(.*)$", | ||
| "file": 1, | ||
| "line": 2, | ||
| "column": 3, | ||
| "code": 4, | ||
| "message": 5 | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| name: Markdownlint | ||
|
|
||
| on: | ||
| pull_request: | ||
| paths: | ||
| - "**/*.md" | ||
| - ".markdownlint.json" | ||
| - ".github/workflows/markdownlint.yml" | ||
| - ".github/workflows/markdownlint-problem-matcher.json" | ||
|
|
||
| jobs: | ||
| lint: | ||
|
|
||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Use Node.js | ||
| uses: actions/setup-node@v1 | ||
| with: | ||
| node-version: 12.x | ||
| - name: Run Markdownlint | ||
| run: | | ||
| echo "::add-matcher::.github/workflows/markdownlint-problem-matcher.json" | ||
| npm i -g markdownlint-cli | ||
| markdownlint "**/*.md" |
Oops, something went wrong.