forked from zulip/zulip
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
migrations: Repeat part of migration 0376.
The blockquote explains the motivation for this change in detail. Fixes zulip#21608.
- Loading branch information
Showing
2 changed files
with
47 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
from django.conf import settings | ||
from django.db import migrations | ||
from django.db.backends.postgresql.schema import DatabaseSchemaEditor | ||
from django.db.migrations.state import StateApps | ||
|
||
from zerver.lib.queue import queue_json_publish | ||
|
||
|
||
def reupload_realm_emoji(apps: StateApps, schema_editor: DatabaseSchemaEditor) -> None: | ||
"""As detailed in https://github.com/zulip/zulip/issues/21608, it is | ||
possible for the deferred_work queue from Zulip 4.x to have been | ||
started up by puppet during the deployment before migrations were | ||
run on Zulip 5.0. | ||
This means that the deferred_work events produced by migration | ||
0376 might have been processed and discarded without effect. | ||
Since it's harmless to reupload a custom emoji a second time, we | ||
fix this issue for the slice of servers that have already | ||
installed 5.0 by repeating that part of the migration. | ||
""" | ||
|
||
Realm = apps.get_model("zerver", "Realm") | ||
if settings.TEST_SUITE: | ||
# There are no custom emoji in the test suite data set, and | ||
# the below code won't work because RabbitMQ isn't enabled for | ||
# the test suite. | ||
return | ||
|
||
for realm_id in Realm.objects.order_by("id").values_list("id", flat=True): | ||
event = { | ||
"type": "reupload_realm_emoji", | ||
"realm_id": realm_id, | ||
} | ||
queue_json_publish("deferred_work", event) | ||
|
||
|
||
class Migration(migrations.Migration): | ||
|
||
dependencies = [ | ||
("zerver", "0386_fix_attachment_caches"), | ||
] | ||
|
||
operations = [ | ||
migrations.RunPython(reupload_realm_emoji, reverse_code=migrations.RunPython.noop), | ||
] |