This repository has been archived by the owner on Dec 28, 2022. It is now read-only.
Fix slow library loading with a lot of inclusions or exclusions #535
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #534 - the library loads very slowly when there are entries in the blacklist. Seems that I found the issue - there was a hidden
O(N^2)
loop in the incl/excl filtering algorithm.I converted the include/exclude path lists to hash sets that have fast member checks and this seems to solve the performance problems:
Now if I'm not mistaken, this should now be O(N) and scale a little better.