Skip to content

Commit

Permalink
filters: change untagged to dangling
Browse files Browse the repository at this point in the history
Docker-DCO-1.1-Signed-off-by: Vincent Batts <[email protected]> (github: vbatts)
  • Loading branch information
vbatts committed Jun 2, 2014
1 parent f322168 commit 3ecfaa8
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion api/client/commands.go
Original file line number Diff line number Diff line change
Expand Up @@ -1148,7 +1148,7 @@ func (cli *DockerCli) CmdImages(args ...string) error {
flTree := cmd.Bool([]string{"#t", "#tree", "#-tree"}, false, "Output graph in tree format")

var flFilter opts.ListOpts
cmd.Var(&flFilter, []string{"f", "-filter"}, "Provide filter values (i.e. 'tagged=false')")
cmd.Var(&flFilter, []string{"f", "-filter"}, "Provide filter values (i.e. 'dangling=true')")

if err := cmd.Parse(args); err != nil {
return nil
Expand Down
8 changes: 4 additions & 4 deletions docs/sources/reference/commandline/cli.md
Original file line number Diff line number Diff line change
Expand Up @@ -440,7 +440,7 @@ To see how the `docker:latest` image was built:
List images

-a, --all=false Show all images (by default filter out the intermediate image layers)
-f, --filter=[]: Provide filter values (i.e. 'tagged=false')
-f, --filter=[]: Provide filter values (i.e. 'dangling=true')
--no-trunc=false Don't truncate output
-q, --quiet=false Only show numeric IDs

Expand Down Expand Up @@ -486,11 +486,11 @@ The filtering flag (-f or --filter) format is of "key=value". If there are more
than one filter, then pass multiple flags (e.g. `--filter "foo=bar" --filter "bif=baz"`)

Current filters:
* untagged (boolean - true or false)
* dangling (boolean - true or false)

#### untagged images

$ sudo docker images --filter "untagged=true"
$ sudo docker images --filter "dangling=true"

REPOSITORY TAG IMAGE ID CREATED VIRTUAL SIZE
<none> <none> 8abc22fbb042 4 weeks ago 0 B
Expand All @@ -508,7 +508,7 @@ By having this flag it allows for batch cleanup.

Ready for use by `docker rmi ...`, like:

$ sudo docker rmi $(sudo docker images -f "untagged=true" -q)
$ sudo docker rmi $(sudo docker images -f "dangling=true" -q)

8abc22fbb042
48e5f45168b9
Expand Down
2 changes: 1 addition & 1 deletion server/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -704,7 +704,7 @@ func (srv *Server) Images(job *engine.Job) engine.Status {
if err != nil {
return job.Error(err)
}
if i, ok := imageFilters["untagged"]; ok {
if i, ok := imageFilters["dangling"]; ok {
for _, value := range i {
if strings.ToLower(value) == "true" {
filt_tagged = false
Expand Down

0 comments on commit 3ecfaa8

Please sign in to comment.