more open strings. Why does this error?

...in the browser, but not in the tests
tjvr · May 12, 2017 · 8ccfe43 · 8ccfe43
1 parent 0365b29
commit 8ccfe43
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/editor/mode.js b/editor/mode.js
@@ -119,6 +119,8 @@ CodeMirror.defineMode('tosh', module.exports = function(cfg, modeCfg) {
       try {
         completer.feed(line)
 
+        // TODO allow partial tokens
+
       } catch (e) {
         // TODO avoid lexing again
         const lexer = modeCfg.grammar.lexer
@@ -161,8 +163,7 @@ CodeMirror.defineMode('tosh', module.exports = function(cfg, modeCfg) {
 
       let range = this.line.pop()
       if (range.className === 'error' && /^['"]/.test(range.text)) {
-        stream.match(range.text) // consume
-        return 'string'
+        range.className = 'string'
       }
       if (!stream.match(range.text)) { // consume
         throw new Error("Does not match stream")

diff --git a/test/mode.test.js b/test/mode.test.js
@@ -185,6 +185,9 @@ describe('highlight', () => {
   MT('open string',
     '[error say ][string "]')
 
+  MT('open string',
+    '[error say ][string "foo]')
+
   // make sure I don't try to be too efficient looking for open strings
   MT('closed string',
     '[s-looks say] [string "foo "] ')