Fix nil pointer dereference in CompareAppState (argoproj#1234) (argop…

…roj#1240)
tkasuz · Mar 8, 2019 · 461d8c9 · 461d8c9
1 parent 9a7fece
commit 461d8c9
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/controller/state.go b/controller/state.go
@@ -278,7 +278,9 @@ func (m *appStateManager) CompareAppState(app *v1alpha1.Application, revision st
 		conditions:       conditions,
 		hooks:            hooks,
 		diffNormalizer:   diffNormalizer,
-		appSourceType:    v1alpha1.ApplicationSourceType(manifestInfo.SourceType),
+	}
+	if manifestInfo != nil {
+		compRes.appSourceType = v1alpha1.ApplicationSourceType(manifestInfo.SourceType)
 	}
 	return &compRes, nil
 }