fix: label selector is useless when name variable is not set (argopro…

…j#5975) when name variable is empty, the label selector is useless. Signed-off-by: stanhrxu <[email protected]>
tkasuz · Jul 12, 2021 · 9a788c3 · 9a788c3
1 parent dec710e
commit 9a788c3
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/server/application/application.go b/server/application/application.go
@@ -751,7 +751,7 @@ func (s *Server) Watch(q *application.ApplicationQuery, ws application.Applicati
 		if appVersion, err := strconv.Atoi(a.ResourceVersion); err == nil && appVersion < minVersion {
 			return
 		}
-		matchedEvent := q.GetName() == "" || a.Name == q.GetName() && selector.Matches(labels.Set(a.Labels))
+		matchedEvent := (q.GetName() == "" || a.Name == q.GetName()) && selector.Matches(labels.Set(a.Labels))
 		if !matchedEvent {
 			return
 		}