Update rollout healthcheck to use pause conditons (argoproj#2842)

resource_customizations/argoproj.io/Rollout/health.lua

@@ -34,16 +34,13 @@ end
 
 function checkPaused(obj)
   hs = {}
-  local paused = false
-  if obj.status.verifyingPreview ~= nil then
-    paused = obj.status.verifyingPreview
-  elseif obj.spec.paused ~= nil then
-    paused = obj.spec.paused
+  hs.status = "Suspended"
+  hs.message = "Rollout is paused"
+  if obj.status.pauseConditions ~= nil and table.getn(obj.status.pauseConditions) > 0 then
+    return hs
   end
 
-  if paused then
-    hs.status = "Suspended"
-    hs.message = "Rollout is paused"
+  if obj.spec.paused ~= nil and obj.spec.paused then
     return hs
   end
   return nil

resource_customizations/argoproj.io/Rollout/health_test.yaml

@@ -20,14 +20,6 @@ tests:
     status: Healthy
     message: The active Service is serving traffic to the current pod spec
   inputPath: testdata/bluegreen/healthy_servingActiveService.yaml
-- healthStatus:
-    status: Suspended
-    message: Rollout is paused
-  inputPath: testdata/bluegreen/suspended_servingPreviewService.yaml
-- healthStatus:
-    status: Suspended
-    message: Rollout is paused
-  inputPath: testdata/v0.2_suspended_servingPreviewService.yaml
 - healthStatus:
     status: Progressing
     message: "Waiting for roll out to finish: More replicas need to be updated"
@@ -48,7 +40,11 @@ tests:
 - healthStatus:
     status: Suspended
     message: Rollout is paused
-  inputPath: testdata/canary/suspended_pausedStep.yaml
+  inputPath: testdata/suspended_controllerPause.yaml
+- healthStatus:
+    status: Suspended
+    message: Rollout is paused
+  inputPath: testdata/suspended_userPause.yaml
 - healthStatus:
     status: Healthy
     message: The rollout has completed all steps

resource_customizations/argoproj.io/Rollout/testdata/suspended_controllerPause.yaml

@@ -0,0 +1,52 @@
+apiVersion: argoproj.io/v1alpha1
+kind: Rollout
+metadata:
+  name: canary-demo
+  namespace: default
+spec:
+  replicas: 5
+  revisionHistoryLimit: 1
+  selector:
+    matchLabels:
+      app: canary-demo
+  strategy:
+    canary:
+      canaryService: canary-demo-preview
+      steps:
+      - setWeight: 20
+      - pause: {}
+  template:
+    metadata:
+      creationTimestamp: null
+      labels:
+        app: canary-demo
+    spec:
+      containers:
+      - image: argoproj/rollouts-demo:yellow
+        imagePullPolicy: Always
+        name: canary-demo
+status:
+  HPAReplicas: 5
+  availableReplicas: 5
+  blueGreen: {}
+  canary:
+    stableRS: 75c96899b8
+  conditions:
+  - lastTransitionTime: "2019-12-09T18:34:12Z"
+    lastUpdateTime: "2019-12-09T18:34:12Z"
+    message: Rollout is paused
+    reason: RolloutPaused
+    status: Unknown
+    type: Progressing
+  controllerPause: true
+  currentPodHash: 6758949f55
+  currentStepHash: f64cdc9d
+  currentStepIndex: 1
+  observedGeneration: 5b9f9dd6c6
+  pauseConditions:
+  - reason: CanaryPauseStep
+    startTime: "2019-12-09T18:34:12Z"
+  readyReplicas: 5
+  replicas: 5
+  selector: app=canary-demo
+  updatedReplicas: 1

resource_customizations/argoproj.io/Rollout/testdata/suspended_userPause.yaml

@@ -0,0 +1,46 @@
+apiVersion: argoproj.io/v1alpha1
+kind: Rollout
+metadata:
+  name: example-rollout-canary
+  namespace: default
+spec:
+  paused: true
+  replicas: 5
+  selector:
+    matchLabels:
+      app: guestbook
+  strategy:
+    canary:
+      steps:
+      - setWeight: 20
+      - pause: {}
+  template:
+    metadata:
+      labels:
+        app: guestbook
+    spec:
+      containers:
+      - image: gcr.io/heptio-images/ks-guestbook-demo:0.2
+        name: guestbook
+status:
+  HPAReplicas: 5
+  availableReplicas: 5
+  blueGreen: {}
+  canary:
+    stableRS: df986d68
+  conditions:
+  - lastTransitionTime: 2019-04-26T20:18:38Z
+    lastUpdateTime: 2019-04-26T20:18:38Z
+    message: Rollout is paused
+    reason: RolloutPaused
+    status: Unknown
+    type: Progressing
+  currentPodHash: 6b566f47b7
+  currentStepHash: 6567fc959c
+  currentStepIndex: 1
+  observedGeneration: 5c788f4484
+  pauseStartTime: 2019-04-26T20:18:38Z
+  readyReplicas: 5
+  replicas: 5
+  selector: app=guestbook
+  updatedReplicas: 1