fix removeTagByName for singleField

tksand · Nov 25, 2012 · 15f298b · 15f298b
1 parent f2ec4f6
commit 15f298b
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 13 deletions.
diff --git a/js/tag-it.js b/js/tag-it.js
@@ -352,20 +352,20 @@
             this.tagInput.autocomplete('search', '');
         },
 
-        _existingTag: function(value) {
+        _findTagByName: function(name) {
             var that = this;
             var tag = null;
             this._tags().each(function(i) {
-                if (that._formatStr(value) == that._formatStr(that.tagLabel(this))) {
+                if (that._formatStr(name) == that._formatStr(that.tagLabel(this))) {
                     tag = $(this);
                     return false;
                 }
             });
             return tag;
         },
 
-        _isNew: function(value) {
-            return !this._existingTag(value);
+        _isNew: function(name) {
+            return !this._findTagByName(name);
         },
 
         _formatStr: function(str) {
@@ -389,7 +389,7 @@
             }
 
             if (!this.allowDuplicates && !this._isNew(value)) {
-                var existingTag = this._existingTag(value);
+                var existingTag = this._findTagByName(value);
                 if (this._trigger('onTagExists', null, {
                     existingTag: existingTag,
                     duringInitialization: duringInitialization
@@ -493,8 +493,8 @@
         },
 
         removeTagByName: function(tagName, animate) {
-            var toRemove = this._tags().find("input[value='" + tagName + "']").closest('.tagit-choice');
-            if (toRemove.length === 0) {
+            var toRemove = this._findTagByName(tagName);
+            if (!toRemove) {
                 throw "No such tag exists with the name '" + tagName + "'";
             }
             this.removeTag(toRemove, animate);

diff --git a/js/tag-it.min.js b/js/tag-it.min.js