Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable deferred-decryption per default #539

Closed
wants to merge 1 commit into from
Closed

Conversation

th4s
Copy link
Member

@th4s th4s commented Jul 24, 2024

This PR enables deferred decryption per default. It exposes more fine-grained control over what size is decrypted locally after the TLS connection and what is decrypted online.

@th4s th4s changed the base branch from main to dev July 24, 2024 03:50
@th4s th4s requested review from sinui0 and themighty1 July 24, 2024 04:57
crates/prover/src/tls/config.rs Outdated Show resolved Hide resolved
crates/prover/src/tls/config.rs Outdated Show resolved Hide resolved
crates/prover/src/tls/config.rs Outdated Show resolved Hide resolved
@th4s th4s requested a review from sinui0 July 25, 2024 05:43
@th4s th4s force-pushed the aead-separate-configs branch from e08d15e to 960c8f9 Compare July 25, 2024 06:20
@th4s th4s changed the title Add config value to specify max_offline_size for transcript Add config value to specify max_deferred_size for transcript Jul 25, 2024
@th4s th4s force-pushed the aead-separate-configs branch from 7a1cfff to 4c79460 Compare July 29, 2024 07:34
crates/prover/src/tls/config.rs Outdated Show resolved Hide resolved
crates/verifier/src/tls/config.rs Outdated Show resolved Hide resolved
crates/tls/mpc/src/leader.rs Outdated Show resolved Hide resolved
@th4s th4s force-pushed the aead-separate-configs branch from 4c79460 to aecab74 Compare August 5, 2024 09:10
@th4s th4s requested a review from sinui0 August 5, 2024 09:46
crates/prover/src/tls/config.rs Outdated Show resolved Hide resolved
crates/prover/src/tls/config.rs Outdated Show resolved Hide resolved
crates/prover/src/tls/config.rs Show resolved Hide resolved
crates/verifier/src/tls/config.rs Outdated Show resolved Hide resolved
crates/verifier/src/tls/config.rs Outdated Show resolved Hide resolved
@th4s th4s force-pushed the aead-separate-configs branch 2 times, most recently from 13b5d38 to 81f87fe Compare August 7, 2024 14:23
@th4s th4s requested a review from sinui0 August 7, 2024 14:27
Copy link
Member

@sinui0 sinui0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last thing: Defaults. Most people will want to take advantage of deferred decryption but the defaults you have here assume otherwise. The examples should also be updated with this in mind.

@th4s th4s changed the title Add config value to specify max_deferred_size for transcript Enable default-decryption per default Aug 14, 2024
@th4s th4s changed the title Enable default-decryption per default Enable deferred-decryption per default Aug 14, 2024
@th4s th4s changed the title Enable deferred-decryption per default Enable deferred-decryption per default Aug 14, 2024
@th4s th4s requested a review from heeckhau August 14, 2024 12:04
@th4s
Copy link
Member Author

th4s commented Aug 14, 2024

Currently experiencing #559 locally when testing this branch.

@th4s
Copy link
Member Author

th4s commented Aug 15, 2024

Currently experiencing #559 locally when testing this branch.

This did not have anything to do with #559 and was a bug I introduced, but is now fixed. Rdy for review.

Squashed for rebase:
- Add new field `max_offline_size`.
- Use correct field.
- Adapt prover and verifier config.
- Adapt OT estimation
- Add feedback.
- Apply renaming also for transcript-config in tls-mpc.
- Fix notary server.
- Adapt wasm tests.
- Adapt discord example.
- Add defaults and repair wasm tests.
- Add feedback.
- Adapt method names.
- Add more feedback.
- Adapt ot estimation.
- Make deferred decryption default.
- Adapt wasm configs.
- Add feedback.
- fix: integration test no longer deadlocking.
- Apply defaults to whole workspace.
- Add `max_deferred_size` when default is not used.
- Enable notary server tests
@th4s th4s force-pushed the aead-separate-configs branch from ba5b885 to 4c47080 Compare August 21, 2024 10:29
@th4s
Copy link
Member Author

th4s commented Aug 21, 2024

The rebase is turning into a rewrite so it is easier to open a new PR and redo this.

@th4s th4s closed this Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants