-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable deferred-decryption per default #539
Conversation
e08d15e
to
960c8f9
Compare
max_offline_size
for transcriptmax_deferred_size
for transcript
7a1cfff
to
4c79460
Compare
4c79460
to
aecab74
Compare
13b5d38
to
81f87fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last thing: Defaults. Most people will want to take advantage of deferred decryption but the defaults you have here assume otherwise. The examples should also be updated with this in mind.
max_deferred_size
for transcriptdefault-decryption
per default
default-decryption
per defaultdeferred-decryption
per default
deferred-decryption
per default
Currently experiencing #559 locally when testing this branch. |
Squashed for rebase: - Add new field `max_offline_size`. - Use correct field. - Adapt prover and verifier config. - Adapt OT estimation - Add feedback. - Apply renaming also for transcript-config in tls-mpc. - Fix notary server. - Adapt wasm tests. - Adapt discord example. - Add defaults and repair wasm tests. - Add feedback. - Adapt method names. - Add more feedback. - Adapt ot estimation. - Make deferred decryption default. - Adapt wasm configs. - Add feedback. - fix: integration test no longer deadlocking. - Apply defaults to whole workspace. - Add `max_deferred_size` when default is not used. - Enable notary server tests
ba5b885
to
4c47080
Compare
The rebase is turning into a rewrite so it is easier to open a new PR and redo this. |
This PR enables deferred decryption per default. It exposes more fine-grained control over what size is decrypted locally after the TLS connection and what is decrypted online.