(ffmpeg_core.c) passing a format string without the arguments to log_cb

can result in a crash.
tmtvl · Jun 4, 2016 · 5e5e1e6 · 5e5e1e6
1 parent 94e16e6
commit 5e5e1e6
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/cores/libretro-ffmpeg/ffmpeg_core.c b/cores/libretro-ffmpeg/ffmpeg_core.c
@@ -181,9 +181,14 @@ static struct
 #ifdef HAVE_SSA
 static void ass_msg_cb(int level, const char *fmt, va_list args, void *data)
 {
+   char buffer[4096];
    (void)data;
+
    if (level < 6)
-      log_cb(RETRO_LOG_INFO, fmt);
+   {
+      vsnprintf(buffer, sizeof(buffer), fmt, args);
+      log_cb(RETRO_LOG_INFO, "%s\n", buffer);
+   }
 }
 #endif