Skip to content

Commit

Permalink
Remove an incorrect double-check
Browse files Browse the repository at this point in the history
Netplay sync incorrectly checked whether the replay pointer was behind
the unread pointer twice, when in the second check it should only have
been checking if it was behind the current execution pointer. Because of
how resimulation works with device sharing, I THINK this could affect
sync. Even if it can't, it's wrong.
  • Loading branch information
GregorR committed Mar 4, 2018
1 parent 1d1acc8 commit a39bff6
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions network/netplay/netplay_sync.c
Original file line number Diff line number Diff line change
Expand Up @@ -768,8 +768,7 @@ void netplay_sync_post_frame(netplay_t *netplay, bool stalled)

/* Now replay the real input if we've gotten ahead of it */
if (netplay->force_rewind ||
(netplay->replay_frame_count < netplay->unread_frame_count &&
netplay->replay_frame_count < netplay->run_frame_count))
netplay->replay_frame_count < netplay->run_frame_count)
{
retro_ctx_serialize_info_t serial_info;

Expand Down

0 comments on commit a39bff6

Please sign in to comment.