Caching analyzed methods map for performance

tom-pryor · May 24, 2013 · e56eefe · e56eefe
1 parent b9e5266
commit e56eefe
Showing 1 changed file with 14 additions and 1 deletion.
diff --git a/library/Zend/Stdlib/Hydrator/Filter/OptionalParametersFilter.php b/library/Zend/Stdlib/Hydrator/Filter/OptionalParametersFilter.php
@@ -18,11 +18,24 @@
  */
 class OptionalParametersFilter implements FilterInterface
 {
+    /**
+     * Map of methods already analyzed
+     * by {@see \Zend\Stdlib\Hydrator\Filter\OptionalParametersFilter::filter()},
+     * cached for performance reasons
+     *
+     * @var bool[]
+     */
+    private static $propertiesCache = array();
+
     /**
      * {@inheritDoc}
      */
     public function filter($property)
     {
+        if (isset(self::$propertiesCache[$property])) {
+            return self::$propertiesCache[$property];
+        }
+
         try {
             $reflectionMethod = new ReflectionMethod($property);
         } catch (ReflectionException $exception) {
@@ -36,6 +49,6 @@ function (ReflectionParameter $parameter) {
             }
         );
 
-        return empty($mandatoryParameters);
+        return self::$propertiesCache[$property] = empty($mandatoryParameters);
     }
 }