Don't let AFURLConnectionOperation accept a nil request

Closes #1064
tomasikp · Jun 14, 2013 · babd06c · babd06c
1 parent 2853215
commit babd06c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/AFNetworking/AFURLConnectionOperation.m b/AFNetworking/AFURLConnectionOperation.m
@@ -267,6 +267,8 @@ + (NSArray *)pinnedPublicKeys {
 #endif
 
 - (id)initWithRequest:(NSURLRequest *)urlRequest {
+    NSParameterAssert(urlRequest);
+
     self = [super init];
     if (!self) {
 		return nil;

diff --git a/Tests/AFURLConnectionOperationTests.m b/Tests/AFURLConnectionOperationTests.m
@@ -37,6 +37,10 @@ - (void)setUp {
 
 #pragma mark -
 
+- (void)testInitWithNilRequestRaisesException {
+    expect(^{ (void)[[AFURLConnectionOperation alloc] initWithRequest:nil]; }).to.raiseAny();
+}
+
 - (void)testThatAFURLConnectionOperationInvokesWillSendRequestForAuthenticationChallengeBlock {
     NSURLRequest *request = [NSURLRequest requestWithURL:[NSURL URLWithString:@"/path" relativeToURL:self.baseURL]];
     AFURLConnectionOperation *operation = [[AFURLConnectionOperation alloc] initWithRequest:request];