ReactDOMComponent optimization

Slight optimization to not do unneeded reconciles of DOM components
tommyinbi · Mar 10, 2014 · 5ede7fb · 5ede7fb
1 parent 3ea3274
commit 5ede7fb
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/src/core/__tests__/ReactDOM-test.js → src/browser/__tests__/ReactDOM-test.js b/src/core/__tests__/ReactDOM-test.js → src/browser/__tests__/ReactDOM-test.js
diff --git a/src/browser/ui/ReactDOMComponent.js b/src/browser/ui/ReactDOMComponent.js
@@ -206,6 +206,15 @@ ReactDOMComponent.Mixin = {
   },
 
   receiveComponent: function(nextComponent, transaction) {
+    if (nextComponent === this) {
+      // Since props and context are immutable after the component is
+      // mounted, we can do a cheap identity compare here to determine
+      // if this is a superfluous reconcile.
+
+      // TODO: compare the descriptor
+      return;
+    }
+
     assertValidProps(nextComponent.props);
     ReactComponent.Mixin.receiveComponent.call(
       this,

diff --git a/src/core/__tests__/ReactDOMComponent-test.js → ...er/ui/__tests__/ReactDOMComponent-test.js b/src/core/__tests__/ReactDOMComponent-test.js → ...er/ui/__tests__/ReactDOMComponent-test.js