remove data-bind when it's empty

tomorr2000 · Feb 15, 2019 · 5b4dc1b · 5b4dc1b
1 parent 2f8c78c
commit 5b4dc1b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/spec/converter-spec.js b/spec/converter-spec.js
@@ -53,7 +53,7 @@ describe('Template converter', function() {
     var expectedTemplates = [{
       optionalName: 'template',
       templateMode: 'show',
-      html: '<replacedhtml data-bind=""><replacedhead></replacedhead><repleacedbody><div data-bind="block: mainBlocks"></div></repleacedbody></replacedhtml>'
+      html: '<replacedhtml><replacedhead></replacedhead><repleacedbody><div data-bind="block: mainBlocks"></div></repleacedbody></replacedhtml>'
     }, {
       optionalName: 'simpleBlock',
       templateMode: 'show',

diff --git a/src/js/converter/declarations.js b/src/js/converter/declarations.js
@@ -238,7 +238,8 @@ var elaborateDeclarations = function(style, declarations, templateUrlConverter,
 
     var currentBindings = domutils.getAttribute(element, 'data-bind');
     var dataBind = (currentBindings !== null ? currentBindings + ", " : "") + _bindingSerializer(newBindings);
-    domutils.setAttribute(element, 'data-bind', dataBind);
+    if (dataBind == '') domutils.removeAttribute(element, 'data-bind');
+    else domutils.setAttribute(element, 'data-bind', dataBind);
   }
 
   // TODO a function whose return type depends on the input parameters is very ugly.. please FIX ME.