SAK-32489: Manually creating citations causes duplicate sections (sak…

…aiproject#4345)

citations/citations-impl/impl/src/java/org/sakaiproject/citation/impl/DbCitationService.java

@@ -359,6 +359,8 @@ else if(value instanceof String)
 		*/
 		protected void commitCitationCollectionOrder(CitationCollectionOrder citationCollectionOrder)
 		{
+			deleteCitationCollectionOrder(citationCollectionOrder);
+
 			String orderStatement = "insert into " + m_collectionOrderTableName + " (COLLECTION_ID, CITATION_ID, LOCATION, SECTION_TYPE, VALUE) VALUES(?,?,?,?,?)";
 
 			Object[] orderFields = new Object[5];
@@ -1110,6 +1112,23 @@ protected void insertSchemaField(Field field, String schemaId)
 			}
 		}
 
+		/* (non-Javadoc)
+		* @see org.sakaiproject.citation.impl.BaseCitationService.Storage#deleteCitationCollectionOrder(rg.sakaiproject.citation.api.CitationCollectionOrder))
+		*/
+		protected void deleteCitationCollectionOrder(CitationCollectionOrder citationCollectionOrder)
+		{
+			String statement = "delete from " + m_collectionOrderTableName + " where (" + m_collectionTableId + " = ? AND " +
+					"LOCATION = ? AND SECTION_TYPE = ? AND VALUE = ? )";
+
+			Object fields[] = new Object[4];
+			fields[0] = citationCollectionOrder.getCollectionId();
+			fields[1] = citationCollectionOrder.getLocation();
+			fields[2] = citationCollectionOrder.getSectiontype();
+			fields[3] = citationCollectionOrder.getValue();
+
+			boolean ok = m_sqlService.dbWrite(statement, fields);
+		}
+
 		/* (non-Javadoc)
 		 * @see org.sakaiproject.citation.impl.BaseCitationService.Storage#putSchemas(java.util.Collection)
 		 */