Skip to content

Commit

Permalink
Fix zip_safe field not being used with V2 binary (pantsbuild#9598)
Browse files Browse the repository at this point in the history
Due to oversight, we weren't actually translating the field into the appropriate Pex argument.

[ci skip-rust-tests]
[ci skip-jvm-tests]
  • Loading branch information
Eric-Arellano authored Apr 21, 2020
1 parent d04133e commit d4d44c2
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/python/pants/backend/python/rules/python_create_binary.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ def generate_additional_args(self) -> Tuple[str, ...]:
args.append(f"--inherit-path={self.inherit_path.value}")
if self.shebang.value is not None:
args.append(f"--python-shebang={self.shebang.value}")
if self.zip_safe.value is False:
args.append(f"--not-zip-safe")
return tuple(args)


Expand Down

0 comments on commit d4d44c2

Please sign in to comment.