refactor(core): Changed tests to use a constants platforms

Signed-off-by: Felipe Avelar <[email protected]>
torarganaft · Nov 19, 2021 · 241c6a0 · 241c6a0
1 parent efc6bcf
commit 241c6a0
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 23 deletions.
diff --git a/e2e/utils/html.go b/e2e/utils/html.go
@@ -12,15 +12,15 @@ import (
 	"golang.org/x/net/html"
 )
 
-var availablePlatforms = map[string]string{
-	"Ansible":              "ansible",
-	"CloudFormation":       "cloudFormation",
-	"Common":               "common",
-	"Dockerfile":           "dockerfile",
-	"Kubernetes":           "k8s",
-	"OpenAPI":              "openAPI",
-	"Terraform":            "terraform",
-	"AzureResourceManager": "azureResourceManager",
+var availablePlatforms = initPlatforms()
+
+func initPlatforms() map[string]string {
+	platforms := make(map[string]string)
+	for k, v := range constants.AvailablePlatforms {
+		platforms[k] = v
+	}
+	platforms["Common"] = "common"
+	return platforms
 }
 
 // HTMLValidation executes many asserts to validate the HTML Report

diff --git a/internal/constants/constants.go b/internal/constants/constants.go
@@ -41,12 +41,12 @@ var (
 	// AvailablePlatforms - All platforms available
 	AvailablePlatforms = map[string]string{
 		"Ansible":              "ansible",
-		"CloudFormation":       "cloudformation",
+		"CloudFormation":       "cloudFormation",
 		"Dockerfile":           "dockerfile",
 		"Kubernetes":           "k8s",
+		"OpenAPI":              "openAPI",
 		"Terraform":            "terraform",
-		"OpenAPI":              "openapi",
-		"AzureResourceManager": "azureresourcemanager",
+		"AzureResourceManager": "azureResourceManager",
 	}
 
 	// AvailableSeverities - All severities available

diff --git a/test/queries_content_test.go b/test/queries_content_test.go
@@ -52,17 +52,8 @@ var (
 	}
 
 	// TODO uncomment this test once all metadata are fixed
-	availablePlatforms = map[string]string{
-		"Ansible":              "ansible",
-		"CloudFormation":       "cloudFormation",
-		"Common":               "common",
-		"Dockerfile":           "dockerfile",
-		"Kubernetes":           "k8s",
-		"OpenAPI":              "openAPI",
-		"Terraform":            "terraform",
-		"AzureResourceManager": "azureResourceManager",
-	}
-	platformKeys = MapToStringSlice(availablePlatforms)
+	availablePlatforms = initPlatforms()
+	platformKeys       = MapToStringSlice(availablePlatforms)
 
 	CategoriesKeys = MapToStringSlice(constants.AvailableCategories)
 
@@ -120,6 +111,15 @@ var (
 	}
 )
 
+func initPlatforms() map[string]string {
+	platforms := make(map[string]string)
+	for k, v := range constants.AvailablePlatforms {
+		platforms[k] = v
+	}
+	platforms["Common"] = "common"
+	return platforms
+}
+
 func TestQueriesContent(t *testing.T) {
 	log.Logger = log.Output(zerolog.ConsoleWriter{Out: io.Discard})