Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic support for geometry package #133

Merged
merged 2 commits into from
Nov 30, 2020
Merged

Conversation

blipp
Copy link
Contributor

@blipp blipp commented Nov 29, 2020

I found out about YaLafi yesterday, and it was of great help for checking a large LaTeX document. Many thanks!

Here is my first attempt to contribute, by adding basic support for the geometry package: simply ignoring the parameter of the geometry command.

@matze-dd
Copy link
Collaborator

Thank you for this!

I found out about YaLafi yesterday, and it was of great help for checking a large LaTeX document. Many thanks!

Glad to hear that it is useful for you.

Here is my first attempt to contribute, by adding basic support for the geometry package: simply ignoring the parameter of the geometry command.

This looks nice. Only one minor suggestion: The initial comments in geometry.py rather relate to the mathematics stuff from amsmath.py. I would prefer to remove them, here.

@blipp
Copy link
Contributor Author

blipp commented Nov 30, 2020

This looks nice. Only one minor suggestion: The initial comments in geometry.py rather relate to the mathematics stuff from amsmath.py. I would prefer to remove them, here.

Oups, this was left over when I copied from the amsmath package. I added a commit that removes the comment.

@matze-dd matze-dd merged commit 6d17127 into torik42:master Nov 30, 2020
@matze-dd
Copy link
Collaborator

Thanks for the contribution! It has been merged.

@blipp blipp deleted the blipp_geometry branch November 30, 2020 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants