Skip to content

Commit

Permalink
build: drop use of --typeRoots for default_app (electron#26094)
Browse files Browse the repository at this point in the history
  • Loading branch information
dsanders11 authored Oct 28, 2020
1 parent d2727f5 commit 0603ef7
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 8 deletions.
1 change: 0 additions & 1 deletion BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,6 @@ target_gen_default_app_js = "$target_gen_dir/js/default_app"

typescript_build("default_app_js") {
deps = [ ":build_electron_definitions" ]
type_root = rebase_path("$target_gen_dir/tsc/electron/typings")

sources = filenames.default_app_ts_sources

Expand Down
7 changes: 0 additions & 7 deletions build/tsc.gni
Original file line number Diff line number Diff line change
Expand Up @@ -26,19 +26,12 @@ template("typescript_build") {
"//electron/typings/internal-electron.d.ts",
]

type_roots = "node_modules/@types,typings"
if (defined(invoker.type_root)) {
type_roots += "," + invoker.type_root
}

base_out_path = invoker.output_gen_dir + "/electron/"
args = [
"-p",
rebase_path(invoker.tsconfig),
"--outDir",
rebase_path("$base_out_path" + invoker.output_dir_name),
"--typeRoots",
type_roots,
]

outputs = []
Expand Down

0 comments on commit 0603ef7

Please sign in to comment.