remove Handshake state check (microsoft#3321)

* remove Handshake state check * add doc * add detail
tosunkaya · Jan 3, 2023 · 55dd0a5 · 55dd0a5
1 parent 97616f7
commit 55dd0a5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/docs/Settings.md b/docs/Settings.md
@@ -161,7 +161,7 @@ These parameters are accessed by calling [GetParam](./api/GetParam.md) or [SetPa
 | `QUIC_PARAM_CONN_DATAGRAM_SEND_ENABLED`<br> 14    | uint8_t (BOOLEAN)             | Get-only  | Indicates peer advertised support for QUIC datagram extension. Call after connected.      |
 | `QUIC_PARAM_CONN_DISABLE_1RTT_ENCRYPTION`<br> 15  | uint8_t (BOOLEAN)             | Both      | Application must `#define QUIC_API_ENABLE_INSECURE_FEATURES` before including msquic.h.   |
 | `QUIC_PARAM_CONN_RESUMPTION_TICKET`<br> 16        | uint8_t[]                     | Set-only  | Must be set on client before starting connection.                                         |
-| `QUIC_PARAM_CONN_PEER_CERTIFICATE_VALID`<br> 17   | uint8_t (BOOLEAN)             | Set-only  | Used for asynchronous custom certificate validation.                                      |
+| `QUIC_PARAM_CONN_PEER_CERTIFICATE_VALID`<br> 17   | uint8_t (BOOLEAN)             | Set-only  | Used for asynchronous custom certificate validation. *Deprecated soon. Replaced by [ConnectionCertificateValidationComplete]*                                     |
 | `QUIC_PARAM_CONN_LOCAL_INTERFACE`<br> 18          | uint32_t                      | Set-only  | The local interface index to bind to.                                                     |
 | `QUIC_PARAM_CONN_TLS_SECRETS`<br> 19              | QUIC_TLS_SECRETS              | Set-only  | The TLS secrets struct to be populated by MsQuic.                                         |
 | `QUIC_PARAM_CONN_VERSION_SETTINGS`<br> 20         | QUIC_VERSION_SETTINGS         | Both      | The desired QUIC versions for the connection.                                             |
@@ -213,3 +213,5 @@ These parameters are access by calling [GetParam](./api/GetParam.md) or [SetPara
 [QUIC_SETTINGS](./api/QUIC_SETTINGS.md)<br>
 [GetParam](./api/GetParam.md)<br>
 [SetParam](./api/SetParam.md)<br>
+
+[ConnectionCertificateValidationComplete]: ./api/ConnectionCertificateValidationComplete.md
diff --git a/src/core/api.c b/src/core/api.c
@@ -1761,11 +1761,6 @@ MsQuicConnectionCertificateValidationComplete(
         goto Error;
     }
 
-    if (Connection->Crypto.TlsState.HandshakeComplete) {
-        Status = QUIC_STATUS_INVALID_STATE;
-        goto Error;
-    }
-
     Oper = QuicOperationAlloc(Connection->Worker, QUIC_OPER_TYPE_API_CALL);
     if (Oper == NULL) {
         Status = QUIC_STATUS_OUT_OF_MEMORY;