Wrapping plugin block in a check for global window object

- window might not be available, i.e. when rendering React components server-side
touchX · Nov 4, 2016 · 6f0d751 · 6f0d751
1 parent 4d77d57
commit 6f0d751
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 18 deletions.
diff --git a/dist/shave.js b/dist/shave.js
@@ -58,15 +58,17 @@ function shave(target, maxHeight, opts) {
   }
 }
 
-var plugin = window.$ || window.jQuery || window.Zepto;
-if (plugin) {
-  plugin.fn.extend({
-    shave: function shaveFunc(maxHeight, opts) {
-      return shave(this, maxHeight, opts);
-    }
-  });
+if (typeof window !== 'undefined') {
+  var plugin = window.$ || window.jQuery || window.Zepto;
+  if (plugin) {
+    plugin.fn.extend({
+      shave: function shaveFunc(maxHeight, opts) {
+        return shave(this, maxHeight, opts);
+      }
+    });
+  }
 }
 
 return shave;
 
-})));
+})));
diff --git a/dist/shave.min.js b/dist/shave.min.js
diff --git a/src/shave.js b/src/shave.js
@@ -55,11 +55,13 @@ export default function shave(target, maxHeight, opts) {
   }
 }
 
-const plugin = window.$ || window.jQuery || window.Zepto;
-if (plugin) {
-  plugin.fn.extend({
-    shave: function shaveFunc(maxHeight, opts) {
-      return shave(this, maxHeight, opts);
-    },
-  });
+if (typeof window !== 'undefined') {
+  const plugin = window.$ || window.jQuery || window.Zepto;
+  if (plugin) {
+    plugin.fn.extend({
+      shave: function shaveFunc(maxHeight, opts) {
+        return shave(this, maxHeight, opts);
+      },
+    });
+  }
 }