Fix - webview is shown after cancellation from the app. (#13)

* It should just validate that's the proper callback url * remove redundancy * remove dead code
touren · May 16, 2020 · baac2e3 · baac2e3
1 parent aa17aff
commit baac2e3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/TwitterKit/TwitterKit/Social/Identity/TWTRLoginURLParser.m b/TwitterKit/TwitterKit/Social/Identity/TWTRLoginURLParser.m
@@ -69,7 +69,7 @@ - (BOOL)isMobileSSOSuccessURL:(NSURL *)url
 - (BOOL)isMobileSSOCancelURL:(NSURL *)url
 {
     BOOL properScheme = [self isTwitterKitRedirectURL:url];
-    BOOL cancelState = (url.host == nil) && properScheme;
+    BOOL cancelState = (url.host == nil);
 
     BOOL isCancelURL = properScheme && cancelState;
 

diff --git a/TwitterKit/TwitterKit/Social/Identity/TWTRMobileSSO.m b/TwitterKit/TwitterKit/Social/Identity/TWTRMobileSSO.m
@@ -77,9 +77,7 @@ - (BOOL)isWebWithSourceApplication:(NSString *)sourceApplication
 - (BOOL)isSSOWithURL:(NSURL *)url
 {
     if (url == nil) return NO;
-    return [url.host containsString:@"secret="] &&
-    [url.host containsString:@"secret="] &&
-    [url.host containsString:@"username="] ;
+    return [self.loginURLParser isTwitterKitRedirectURL:url];
 }
 
 - (BOOL)isWebWithURL:(NSURL *)url