config: use figment to merge config file with env vars #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stintel
force-pushed
the
feature/config_from_env
branch
from
50ace4c to
1b79575
Compare
stintel
force-pushed
the
feature/config_from_env
branch
from
1b79575 to
a867c28
Compare
This makes it possible to override the configuration in the TOML config file with environment variables. Adding a test for this seems prohibitively difficult, as setting the environment variable in the build script, or even using Figment's jail feature, seems to impact the other tests.
stintel
force-pushed
the
feature/config_from_env
branch
from
a867c28 to
3849084
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to override the configuration in the TOML config
file with environment variables.
Adding a test for this seems prohibitively difficult, as setting the
environment variable in the build script, or even using Figment's jail
feature, seems to impact the other tests.