Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add More Languages! #26

Closed
wants to merge 12 commits into from
Closed

Add More Languages! #26

wants to merge 12 commits into from

Conversation

trvrplk
Copy link

@trvrplk trvrplk commented Oct 19, 2012

So far I've added some basic support for JavaScript.

@trvrplk
Copy link
Author

trvrplk commented Oct 20, 2012

85f9c9e

@tpope
Copy link
Owner

tpope commented Oct 21, 2012

I feel like punctuation closing is a pretty poor fit for endwise. For example, this common JavaScript pattern makes the provided JavaScript support fall flat on its face:

(function() {

But I think the problem is larger than specific examples. Nobody stacks multiple ends on a line, but it's the norm when your structures are made up of punctuation.

I have some vague ideas how a good punctuation closer might behave, but the smattering of JavaScript I write isn't enough to drive me to follow through.

@tpope tpope closed this Oct 21, 2012
@tpope tpope mentioned this pull request Oct 21, 2012
@trvrplk
Copy link
Author

trvrplk commented Oct 21, 2012

OK, whatever, I'll continue to maintain my fork for personal use and anyone else who is interested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants