Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support the Julia language #72

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bicycle1885
Copy link

Hello,

This plugin greatly save my coding time and I want to enjoy it with my favorite language: Julia.
This pull request adds the support of Julia.
I'm not sure if this works completely, but I didn't see false positives or false negatives while my half-hour coding.

@bicycle1885
Copy link
Author

Ah, these syntax group names were derived from the julia-vim plugin.

@ararslan
Copy link

Bump! I was hoping for this functionality for Julia and came across this PR. Looks like @tpope hasn't been around in a while, but @bicycle1885, would you be willing to rebase and resolve conflicts anyway to ensure this is mergeable whenever Tim returns?

@bicycle1885
Copy link
Author

Thank you for being interested in this pull request, but unfortunately I'm not using vim-endwise now and so I can't do dogfooding.

I think fixing this and creating a new pull request are almost trivial. So, could you try to make it yourself?

@ararslan
Copy link

Sure, will do. Thanks!

@tpope
Copy link
Owner

tpope commented Sep 15, 2016

I will merge if it's updated.

@ararslan
Copy link

I forked the repo, applied these changes to a branch, and have been testing out the changes, but I can't seem to get it to work at all with Julia. I think it has something to do with how julia-vim is set up; the blocks aren't defined with syntax match like in Ruby, for example, but rather with syntax region and syntax cluster. Could that be throwing it off?

By the way, hello Tim Pope! Thanks for making such awesome Vim stuff.

@tpope
Copy link
Owner

tpope commented Apr 27, 2017

Haven't looked at the implementation, but Ruby uses syntax region for blocks, so I'm not sure what you're asking. You can generally get the correct group by using zS from scriptease.vim.

@00sapo
Copy link

00sapo commented Jun 27, 2021

Please, give a look at #128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants