Default controller projection to ApplicationController #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to how `:Einitializer` with no arguments defaults to the routes file, `:Econtroller` with no arguments should default to `ApplicationController`. This seems like a reasonable default because AFAICT all Rails applications are generated with this as the default top-level controller (even when the `--api` option is used).
|
There's already a default, based on the file you are currently editing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to how
:Einitializerwith no arguments defaults to the routes file,:Econtrollerwith no arguments should default toApplicationController. This seems like a reasonable default because AFAICT all Rails applications are generated with this as the default top-level controller (even with the--apioption).This PR has the side effect of creating
application_controller.rbif it doesn't exist. That seems unexpected to me, but I couldn't figure out an implementation that doesn't do that.