Fix “E54: Unmatched (” when jumping to related from a .sql
file
#580
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following error when invoking
:R
from a.sql
file:The problem is the
s:sql_define
pattern sets\v
(very magic mode) which is then embedded into amatchstr
pattern insides:readable_last_method
which does not expect the magic mode to the changed from the default.I saw two options for solving this:
s:sql_define
pattern to reset back to magic mode (\m
), ors:readable_last_method
to reset back to magic mode (\m
) after embeddingself.define_pattern()
The second option seemed to be more robust against other pattern inputs and I did not see
s:sql_define
being used as a part of other patterns elsewhere.