trace-server: modify visibility of WebApplication methods

Simplify the extension of WebApplication class. After this commit, an user interested in creating an own custom trace-server, can easily extend the WebApplication class. Change-Id: I6c130501b31747f650431a669d77a31fcab83f83 Signed-off-by: Francesco Robino <[email protected]> Reviewed-on: https://git.eclipse.org/r/c/tracecompass.incubator/org.eclipse.tracecompass.incubator/+/181194 Tested-by: Matthew Khouzam <[email protected]> Tested-by: Trace Compass Bot <[email protected]> Reviewed-by: Matthew Khouzam <[email protected]> Reviewed-by: Bernd Hufmann <[email protected]>
tracecompass · Jun 1, 2021 · f13c8c7 · f13c8c7
1 parent 24028b2
commit f13c8c7
Showing 1 changed file with 18 additions and 2 deletions.
diff --git a/.../tracecompass/incubator/internal/trace/server/jersey/rest/core/webapp/WebApplication.java b/.../tracecompass/incubator/internal/trace/server/jersey/rest/core/webapp/WebApplication.java
@@ -142,7 +142,17 @@ public void start() throws Exception {
         }
     }
 
-    private static ServerConnector getConnector(Server server, TraceServerConfiguration config) {
+    /**
+     * Given a server instance and its preferred configuration, a properly
+     * configured ServerConnector for the Jetty server is returned.
+     *
+     * @param server
+     *            the server instance
+     * @param config
+     *            a class describing the desired server configuration
+     * @return a configured ServerConnector instance
+     */
+    protected static ServerConnector getConnector(Server server, TraceServerConfiguration config) {
         ServerConnector serverConnector = null;
         if (config.useSSL()) {
 
@@ -168,7 +178,13 @@ private static ServerConnector getConnector(Server server, TraceServerConfigurat
         return serverConnector;
     }
 
-    private static JacksonJaxbJsonProvider registerCustomMappers() {
+    /**
+     * Creates a JSON content type provider configured with custom mappers for
+     * reading and writing JSON from/to custom classes.
+     *
+     * @return the JSON content type provider providing custom mappers.
+     */
+    protected static JacksonJaxbJsonProvider registerCustomMappers() {
         ObjectMapper mapper = new ObjectMapper();
 
         // create JsonProvider to provide custom ObjectMapper