bug fix: close price null from the api causing changePercent to be -I…

…nfinite
tradium-app · Nov 4, 2021 · 9b24281 · 9b24281
1 parent 57ac450
commit 9b24281
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/src/main/java/com/tradiumapp/swingtradealerts/scheduledtasks/FetchLiveQuotesTask.java b/src/main/java/com/tradiumapp/swingtradealerts/scheduledtasks/FetchLiveQuotesTask.java
@@ -62,17 +62,18 @@ public void fetchLiveQuotesTask() throws IOException {
                     Stock stock = stocks.stream().filter(s -> s.symbol.equals(entry.getKey())).findFirst().get();
 
                     IexNewsQuoteResponse.Quote quote = entry.getValue().quote;
-                    stock.price = quote.close;
-                    if (stock.yesterdaysPrice != 0)
+                    if (stock.yesterdaysPrice != 0 && stock.price != 0) {
+                        stock.price = quote.latestPrice;
                         stock.changePercent = ((stock.price - stock.yesterdaysPrice) * 100) / stock.price;
+                    }
                     stock.company = quote.companyName;
                     stock.peRatio = quote.peRatio;
                     stock.week52High = quote.week52High;
                     stock.week52Low = quote.week52Low;
 
                     StockHistory stockHistory = stockHistories.stream().filter(s -> s.symbol.equals(entry.getKey())).findFirst().get();
 
-                    StockHistory.StockPrice intradayPrice = new StockHistory.StockPrice(quote.open, quote.high, quote.low, quote.close, quote.volume);
+                    StockHistory.StockPrice intradayPrice = new StockHistory.StockPrice(quote.open, quote.high, quote.low, quote.latestPrice, quote.volume);
                     if (stockHistory.intraday_priceHistory == null)
                         stockHistory.intraday_priceHistory = new ArrayList<>();
                     stockHistory.intraday_priceHistory.add(intradayPrice);

diff --git a/src/main/java/com/tradiumapp/swingtradealerts/scheduledtasks/UpdateYesterdaysPriceTask.java b/src/main/java/com/tradiumapp/swingtradealerts/scheduledtasks/UpdateYesterdaysPriceTask.java
@@ -50,7 +50,7 @@ public void execute(JobExecutionContext jobExecutionContext) throws JobExecution
                                     && sp.time > yesterdayStartEpoch
                                     && sp.time < yesterdayEndEpoch).findFirst();
 
-                    if (lastPriceOptional.isPresent()) {
+                    if (lastPriceOptional.isPresent() && stockOptional.get().price != 0) {
                         stockOptional.get().yesterdaysPrice = lastPriceOptional.get().close;
                         stockOptional.get().changePercent = ((stockOptional.get().price - stockOptional.get().yesterdaysPrice) * 100) / stockOptional.get().price;
                     }

diff --git a/src/main/java/com/tradiumapp/swingtradealerts/services/models/IexNewsQuoteResponse.java b/src/main/java/com/tradiumapp/swingtradealerts/services/models/IexNewsQuoteResponse.java
@@ -11,7 +11,7 @@ public class Quote {
         public float open;
         public float high;
         public float low;
-        public float close;
+        public float latestPrice;
         public float volume;
         public float peRatio;
         public float week52High;