Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update telemetry docs #29

Merged
merged 7 commits into from
Oct 27, 2021
Merged

Update telemetry docs #29

merged 7 commits into from
Oct 27, 2021

Conversation

ronaktruss
Copy link
Contributor

@ronaktruss ronaktruss commented Oct 21, 2021

I have added a link to some instructions on how to view logs in the load testing environment.

@ronaktruss ronaktruss changed the title Fix spelling on link Update telemetry docs Oct 25, 2021
@ronaktruss ronaktruss marked this pull request as ready for review October 25, 2021 21:46
@ronaktruss ronaktruss requested a review from a team October 25, 2021 21:46
@rogeruiz
Copy link
Contributor

@ronaktruss I haven't been able to get the Docker Compose commands from these docs to work on transcom/mymove#7541. Do they work for you locally?

@ronaktruss
Copy link
Contributor Author

ronaktruss commented Oct 26, 2021

@ronaktruss I haven't been able to get the Docker Compose commands from these docs to work on transcom/mymove#7541. Do they work for you locally?

@rogeruiz I ran into some issues as well, but was able to resolve them by increasing the memory resources available to docker (it was at 2gb and I increased it to 8 or 12). We can pair to see if this resolves the issue and I can also add that those instructions to the docs.

@rogeruiz
Copy link
Contributor

After pairing on this briefly with @ronaktruss, we've found out a couple of things. I'm going to use this space to discuss the Kibana stuff that we found.

After bumping up my memory limits, I was able to get things working locally. Once that was done. I saw that there are a couple of Services and Transactions that seem to be weird to me locally. It'll most likely go away in the future as the feature progresses, but it's good to document this for folks working on the feature and building this out.

Services are all named unknown_service_milmove_gin and all local Transactions besides logging in and logging out are called server-no-tls. I'm not sure where this is coming from, but it seems like it's a fix with big implications for the usefulness of this. The login/logout functionality seems to show up fine in the Kibana dashboard, so I'd probably look there first to see why those are unique to all the other routes.

📸 Some screenshots of what this looks like
Working Kibana Dashboard with Services and Transactions
Captura de Pantalla 2021-10-26 a la(s) 11 52 31
Hypothesis that a local URL shows up as server-no-tls in Kibana
Captura de Pantalla 2021-10-26 a la(s) 11 52 40

@ronaktruss ronaktruss requested a review from rogeruiz October 27, 2021 00:08
Copy link
Contributor

@YanZ777 YanZ777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the docs. Just some minor comments here and there.

docs/tools/telemetry/running-telemetry-locally.md Outdated Show resolved Hide resolved

![Kibana home page](../../../static/img/telemetry/kibana-home-page.png)

1. To start collecting information you must run the mymove app locally. To do this navigate to the mymove repo and run the command `make client_run` to start up the local server. You can then navigate through the app to start collecting data.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do they also have to do make server_run?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that was in the previous step with the Open Telemetry environment variables. I think this section is implying that to show data in Kibana you need to navigate through the application.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! Should have read up a bit! Thanks for the clarification.


![Services Dashboard](../../../static/img/telemetry/services-dashboard.png)

Note: Services are all named unknown_service_milmove_gin and all local transactions besides logging in and logging out are called server-no-tls. This behavior is no ideal and should be looked into. Utilizing local urls such as `officelocal:3000` may be the cause of the lack of semantic naming.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo:
no -> not

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should leave out the "This behavior is not ideal and should be looked into".
Should there be a Jira ticket to fix this sort of thing?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooooh I like this idea. Instead of detailing the issue/bug/task in documentation, we can link to a Jira ticket that has the context for the story/bug/chore/etc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

Copy link
Contributor

@rogeruiz rogeruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This document needs to be migrated due to #36. I have other suggestions as well. but as-is, this document would not be linked to anything given the changes from #36. Sorry @ronaktruss

@rogeruiz rogeruiz dismissed their stale review October 27, 2021 14:55

this request changes was a mistake.

Copy link
Contributor

@rogeruiz rogeruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🌈

Thanks for doing this @ronaktruss. I added some suggested changes but I don't want to hold up the review merge of this PR any longer so I'm approving it. But feel free to incorporate these now, otherwise I'll add them in another PR in the future.

Comment on lines +12 to +18
You may see an error message like: `ERROR: for apm-server Container "4aa42b9f5715" is unhealthy` or `ERROR: for apm-server Container "4aa42b9f5715" is unhealthy` this may be an indication that docker doesn't have enough memory. To resolve this issue open up Docker Desktop. Click the gear icon in the header as shown below:

![docker settings](../../../static/img/telemetry/docker_settings.png)

You can then click `Resources` on the left nav bar and modify the `Memory` slider to `8.00 GB`. Click `Apply & Restart`. Once you have done this rerun the original command.

![changed docker settings](../../../static/img/telemetry/docker_resources.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like use to use Docusaurus Admonitions for big call outs like this.

This is what they look like visually Captura de Pantalla 2021-10-27 a la(s) 12 01 44
Here's a helpful GitHub Suggested Change for adding them in a single click to this PR.
Suggested change
You may see an error message like: `ERROR: for apm-server Container "4aa42b9f5715" is unhealthy` or `ERROR: for apm-server Container "4aa42b9f5715" is unhealthy` this may be an indication that docker doesn't have enough memory. To resolve this issue open up Docker Desktop. Click the gear icon in the header as shown below:
![docker settings](../../../static/img/telemetry/docker_settings.png)
You can then click `Resources` on the left nav bar and modify the `Memory` slider to `8.00 GB`. Click `Apply & Restart`. Once you have done this rerun the original command.
![changed docker settings](../../../static/img/telemetry/docker_resources.png)
:::danger You may encounter errors
Docker Compose may report errors similar to the following: `ERROR: for
apm-server Container "4aa42b9f5715" is unhealthy` or `ERROR: for apm-server
Container "4aa42b9f5715" is unhealthy` this may be an indication that docker
doesn't have enough memory. To resolve this issue open up Docker Desktop. Click
the gear icon in the header as shown below:
![docker settings](/img/telemetry/docker_settings.png)
You can then click `Resources` on the left nav bar and modify the `Memory`
slider to `8.00 GB`. Click `Apply & Restart`. Once you have done this rerun the
original command.
![changed docker settings](/img/telemetry/docker_resources.png)
:::

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this feedback! I didn't know these existed. For now I will be merging these changes as is, but will be adding the admonitions in a separate PR.


If you see the following error `context deadline exceeded` this is an indication that it can't reach the telemetry server.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like use to use Docusaurus Admonitions for big call outs like this.

This is what they look like visually Captura de Pantalla 2021-10-27 a la(s) 12 03 42
Here's a helpful GitHub Suggested Change for adding them in a single click to this PR.
Suggested change
If you see the following error `context deadline exceeded` this is an indication that it can't reach the telemetry server.
:::danger Context deadline exceeded
If you see the following error `context deadline exceeded` this is an indication
that it can't reach the telemetry server.
:::

Copy link
Contributor

@YanZ777 YanZ777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no further comments, thanks for updating this stuff!
The Admonitions that Roger pointed out would be nice, but I am not going to block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants