MB-9609 migrate frontend #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gidjin
force-pushed
the
gidjin/MB-9609_migrate_frontend
branch
from
8c3d208 to
15ff2fc
Compare
rogeruiz
approved these changes
Oct 23, 2021
Comment on lines
+18
to
+21
| frontendSidebar: [{ | ||
| type: 'autogenerated', | ||
| dirName: 'frontend', | ||
| }], |
There was a problem hiding this comment.
This starts the Sidebar.
I'm using this to start my review.
| @@ -1,3 +1,5 @@ | |||
| # Guide to Implementing UI | |||
There was a problem hiding this comment.
Thanks for catching this with the IDs
| docId: 'frontend/index', | ||
| position: 'left', | ||
| label: 'Frontend', | ||
| }, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move Frontend pages to new home. This PR follows the pattern set in #24 but is independent of it.