Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note about eager vs eagerPreload inconsistency #368

Merged
merged 2 commits into from
Jun 29, 2023
Merged

Add note about eager vs eagerPreload inconsistency #368

merged 2 commits into from
Jun 29, 2023

Conversation

PDickeyTruss
Copy link
Contributor

This PR adds a brief note around some inconsistency between Eager and EagerPreload that recently tripped us up when working on this PR.

This primary comes out of discussions had in this thread: https://ustcdp3.slack.com/archives/CP4979J0G/p1685631988724299

@PDickeyTruss PDickeyTruss requested review from reggieriser and a team June 28, 2023 17:51
@PDickeyTruss PDickeyTruss self-assigned this Jun 28, 2023
reggieriser
reggieriser approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@reggieriser reggieriser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one nitpick and a suggestion, but otherwise looks great. 👍

docs/backend/setup/using-eagerpreload-in-pop.md Outdated Show resolved Hide resolved
@PDickeyTruss PDickeyTruss merged commit b95a6dc into main Jun 29, 2023
@PDickeyTruss PDickeyTruss deleted the PD-eager-vs-eager-preload-inconsistency branch June 29, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reggieriser reggieriser reggieriser approved these changes

Assignees

@PDickeyTruss PDickeyTruss

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PDickeyTruss @reggieriser